Skip to content

Fix anonymity bug and author name leaks #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zarifmahmud wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix anonymity bug and author name leaks #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d78e57
Fix anonymity bug/fix author leaks
zarifmahmud Jul 6, 2022
b07cd6a
remove console log
zarifmahmud Jul 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/src/app/components/canvas/canvas.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,7 @@ export class CanvasComponent implements OnInit, OnDestroy {
new FabricPostComponent(post, {
upvotes: upvotes.length,
comments: comments.length,
author: 'Anonymous',
})
);
}
Expand Down
24 changes: 14 additions & 10 deletions frontend/src/app/components/fabric-post/fabric-post.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ const CONTENT_EXTRA_HEIGHT = 55;
export interface PostOptions {
upvotes: number;
comments: number;
author?: string;
}

@Component({
Expand All @@ -39,16 +40,19 @@ export class FabricPostComponent extends fabric.Group {
splitByGrapheme: true,
});

const author = new fabric.Textbox(post.author, {
name: 'author',
width: 300,
left: 18,
top: title.getScaledHeight() + AUTHOR_OFFSET,
fontSize: 13,
fontFamily: 'Helvetica',
fill: '#555555',
splitByGrapheme: true,
});
const author = new fabric.Textbox(
options?.author?.toString() ?? post.author,
{
name: 'author',
width: 300,
left: 18,
top: title.getScaledHeight() + AUTHOR_OFFSET,
fontSize: 13,
fontFamily: 'Helvetica',
fill: '#555555',
splitByGrapheme: true,
}
);

const desc = new fabric.Textbox(
post.desc.length > 200 ? post.desc.substr(0, 200) + '...' : post.desc,
Expand Down