Skip to content

Reimplement colorized data relocation hover diffs #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 29, 2025

Conversation

LagoLunatic
Copy link
Contributor

#154 161dadd Change font color for nonmatching relocs on hover

image

Data diffing doesn't seem to be fully implemented in objdiff-wasm yet, so just putting placeholders in so it compiles.
@encounter
Copy link
Owner

Maybe we can add separators before “Relocation”? That might help it visually flow better. I also think we can ignore custom colors (like Virtual address) in this case, acting more like a “override”, if that makes sense.

@LagoLunatic
Copy link
Contributor Author

Looks like this now:
image

I didn't override the color of "Extern", because that's not a label but the value text. If I implement red/green for values then all the grey text also shows as red/green, which I thought looked like too much of all one color:
image

@encounter
Copy link
Owner

Looks good, thank you!

@encounter encounter merged commit 196c003 into encounter:main Mar 29, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants