PPC: Fix pooled relocation addends being added twice sometimes #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My original pooled relocations implementation had a bug where it wasn't adding multiple addends together when calculating fake relocations:
Both sides should resolve to
g_dComIfG_gameInfo+0x529c, but instead one showedg_dComIfG_gameInfo+0x51d8and the other showed justg_dComIfG_gameInfo.I noticed this and fixed the bad logic when I reimplemented it in #167, which worked in most cases. But I accidentally added the addends twice per instruction, which resulted in the addend being double what it should be in some weird rare cases, like the example I'm using for these screenshots.
After removing the second addition it should really be fixed, both sides resolve to the same addend:
