fix-subscribe:fixing suscbribe with symbol #5
Conversation
fix-subscribe:fixing suscbribe with symbol
update docs for subscribing
merge and adding docs readme
|
i think we can create dev branch for testing it,before merge to main branch |
|
Thanks for pr, but I can't accept it as is. There is no tests, some strange files like |
i think we can create new branch like dev branch |
CODLOP
left a comment
CODLOP
left a comment
There was a problem hiding this comment.
how we can get ticks if callback is not disponible !!
| volume: event.params.p[1].sds_1.s[0].v[5], | ||
| symbol | ||
| } | ||
| // callback(candles) |
There was a problem hiding this comment.
i don't know why you comment the callback !!
| ]) | ||
| connection.subscribe((event: any) => { | ||
| if (event.name = "event") { | ||
| if (event.params.p[1].sds_1?.s !== undefined) { |
There was a problem hiding this comment.
all event.params.p should be event.params
| ]) | ||
|
|
||
|
|
||
| export async function connectAndSubscribe({ connection, symbols, timeframe = 1 }: GetCandlesParams) { |
3 participants
i just add subscribe with symbol and remove unused code