Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JHipster #1984

Merged
merged 10 commits into from
Dec 9, 2022
Merged

Add JHipster #1984

merged 10 commits into from
Dec 9, 2022
+72 −0

Conversation

adriens
Copy link
Contributor

@adriens adriens commented Dec 7, 2022

@adriens
Copy link
Contributor Author

adriens commented Dec 7, 2022

Just let me know if I should put more details at the cycle level

captn3m0
captn3m0 requested changes Dec 7, 2022
View reviewed changes
Copy link
Member

@captn3m0 captn3m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since only one version is actively supported with both security and active support, I'd recommend making it cleaner via:

eolColumn: Supported

Then dropping all the support: dates, and adding a clarification at the bottom:

Only the latest release is supported, with active feature development, and security fixes.

adriens
adriens commented Dec 7, 2022
View reviewed changes
Copy link
Contributor Author

@adriens adriens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes applied rlated to #1984 (review)

captn3m0
captn3m0 reviewed Dec 7, 2022
View reviewed changes
marcwrobel
marcwrobel requested changes Dec 8, 2022
View reviewed changes
adriens
adriens commented Dec 8, 2022
View reviewed changes
Copy link
Contributor Author

@adriens adriens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcwrobel 👍

marcwrobel
marcwrobel requested changes Dec 8, 2022
View reviewed changes
marcwrobel
marcwrobel reviewed Dec 8, 2022
View reviewed changes
marcwrobel
marcwrobel reviewed Dec 8, 2022
View reviewed changes
@marcwrobel marcwrobel self-requested a review December 8, 2022 18:33
marcwrobel
marcwrobel requested changes Dec 8, 2022
View reviewed changes
Copy link
Member

@marcwrobel marcwrobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The versionCommand should be modified.

@adriens
Copy link
Contributor Author

adriens commented Dec 8, 2022

The versionCommand should be modified.

I'm afraid jhipster --version won't give the expected output :

https://stackoverflow.com/a/50603540

image

@marcwrobel marcwrobel self-requested a review December 9, 2022 09:19
@marcwrobel
Copy link
Member

According to https://stackoverflow.com/a/34271990/374236 :

When you run yo jhipster this is written in yellow in the welcome message.

Seems I was wrong, let's forget about it.

@adriens adriens requested review from captn3m0 and removed request for marcwrobel December 9, 2022 09:22
@adriens
Copy link
Contributor Author

adriens commented Dec 9, 2022

Ok, so is there anything else I should fix @marcwrobel @captn3m0 ❔

@marcwrobel
Copy link
Member

I just fixed the changelogTemplate. I will do a final review.

marcwrobel
marcwrobel approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@marcwrobel marcwrobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@captn3m0 captn3m0 changed the title [Request - Product] JHipster 🧔 Adds JHipster Dec 9, 2022
@captn3m0 captn3m0 merged commit e9de211 into endoflife-date:master Dec 9, 2022
@marcwrobel marcwrobel mentioned this pull request Dec 9, 2022
Closed
@adriens adriens changed the title Adds JHipster Add JHipster Dec 9, 2022
@marcwrobel marcwrobel mentioned this pull request Dec 15, 2022
Merged
@marcwrobel marcwrobel added the new-product This PR adds a new product to the website. label Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcwrobel marcwrobel marcwrobel approved these changes

@captn3m0 captn3m0 Awaiting requested review from captn3m0

Assignees
No one assigned
Labels
new-product This PR adds a new product to the website.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adriens @marcwrobel @captn3m0