imquic: reference GHCR image names so the nightly can pull them - #102
Merged
Merged
Conversation
imquic was the only source-built impl whose registration used bare local tags
(imquic-moq-relay, imquic-moq-interop-test). The official runner's 'Pull pre-built
images from GHCR' step only pulls ghcr.io/* images, so imquic's were never fetched
-> imquic skipped every run ('image unavailable'). Point at the GHCR names that
build-images.yml publishes:
- relay -> ghcr.io/englishm/moq-interop-runner-imquic-moq-relay:latest (exists)
- client -> ghcr.io/englishm/moq-interop-runner-imquic-moq-interop-test:latest (needs a
build-images.yml 'imquic-client' run to populate).
gmarzot
added a commit
that referenced
this pull request
Jul 3, 2026
Syncs the POC branch with the merged official-runner fixes (unblocks the preview
workflow, which GitHub had stopped running because the PR conflicted with main).
Conflict resolutions:
- aiomoqt relay + relay.quic MOQT_DRAFT: kept the *shim* (POC, for pinned draft-NN)
AND set the unconfined default order to 16,14,18 (prefer stable 16, pre-release
draft-18 LAST) -- corrects main's 16,18,14.
- moqx draft_versions: took main's [14,16,18] (drops the stale draft-15).
- Kept the POC confinement env (MOQX_MOQT_VERSIONS=[${MOQT_DRAFT_NUM}], aiomoqt DRAFT)
-- the pinned runner needs it; the official runner ignores docker.env.
Brought in from main: moxygen draft-18, interop-report timeout 120, moqx adapter
override removal. (imquic GHCR names await PR #102 merging to main.)
gmarzot
added a commit
that referenced
this pull request
Jul 3, 2026
) The POC pinned/preview runs pull ghcr.io/* images; imquic used bare local tags so it skipped. Point at the GHCR names (relay exists; client needs a build-images.yml imquic-client run). Applied directly here rather than waiting for #102 to land on main.
Collaborator
Author
|
@lminiero "Looks good to me, thanks! As to the per-draft, my demos typically do allow you to force a specific draft version, so it would be trivial for me to expose it as a setting in the interop runner when needed" noting approval from DM. |
| "docker": { | ||
| "image": "imquic-moq-relay", | ||
| "notes": "Build from source: ./builds/imquic/build.sh --target relay" | ||
| "image": "ghcr.io/englishm/moq-interop-runner-imquic-moq-relay:latest", |
Collaborator
There was a problem hiding this comment.
| "docker": { | ||
| "image": "imquic-moq-interop-test", | ||
| "notes": "Build from source: ./builds/imquic/build.sh --target client" | ||
| "image": "ghcr.io/englishm/moq-interop-runner-imquic-moq-interop-test:latest", |
Collaborator
There was a problem hiding this comment.
englishm-cloudflare
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
imquic's images are built and pushed to GHCR by
build-images.yml, but itsimplementations.jsonentry still referenced bare local tags (imquic-moq-relay,imquic-moq-interop-test). Since1a01efb2the nightly's default path pulls onlyghcr.io/*images (grep '^ghcr.io/') and no longer builds from source, so imquic's images were never fetched → imquic skipped every official run ("image unavailable"), which also produced the imquic→aiomoqt-relay skips.Worth noting for context: the bare-tag form is what the contributor docs still prescribe (IMPLEMENTATIONS.md, docs/DOCKER-TESTING.md), and several other impls (
aiomoqt (relay),moq-dev-rs,moq-go,moqx,moxygen) use it too — so this isn't unique to imquic and isn't a registration mistake. imquic just also has GHCR-published images that its entry wasn't pointing at, so pointing it at them is a clean, immediate fix.Fix: point at the GHCR names that
build-images.ymlpublishes:ghcr.io/englishm/moq-interop-runner-imquic-moq-relay:latest— exists, works immediately.ghcr.io/englishm/moq-interop-runner-imquic-moq-interop-test:latest— needs abuild-images.yml→imquic-clientrun to populate the GHCR tag (it isn't there yet).After merge: the imquic relay pairs run right away; the imquic client pairs run once
build-images.ymlhas built+pushed the client image once.Follow-up (out of scope for this PR): the docs still describe the pre-
1a01efb2source-build model. Either update IMPLEMENTATIONS.md / DOCKER-TESTING.md to state that impls participating in the nightly need GHCR-qualified names, or restore a source-build fallback — and audit the other bare-tag impls above for the same silent skip.🤖 Generated with Claude Code