Add moqx client role#66
Open
gmarzot wants to merge 1 commit into
Open
Conversation
moqx's interop-client image is published by moqx ci-main alongside the relay image (multi-arch, FROM debian:bookworm). Adding the client role makes moqx appear in both relay and client columns of the interop matrix — full NxN coverage rather than relay-only. Mirrors moxygen's existing client entry. Image accepts the runner's standard RELAY_URL / TESTCASE / TLS_DISABLE_VERIFY env convention and emits TAP v14 to stdout.
91267ad to
09c5c32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a `client` role block to moqx's existing entry in `implementations.json`. Mirrors the pattern moxygen already uses.
moqx is currently registered relay-only, so it only appears in the relay column of the interop matrix. The moqx project already publishes an interop-client image (built alongside the relay image from the same tarball via multi-stage `FROM debian:bookworm AS builder`), so wiring it in here closes the loop.
Diff
```json
"moqx": {
...
"roles": {
"relay": { ... },
"client": {
"docker": {
"image": "ghcr.io/openmoq/moqx-interop-client:latest"
}
}
}
}
```
Image details
Runner conventions
The binary honors the runner's env-var conventions natively:
Output is TAP v14 to stdout. Same interface as moxygen's moq-interop-client since both link the same moxygen client library.
Test plan