Add support for API keys #14188
Open
Add support for API keys #14188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somebody1234
added
CI: No changelog needed
PabloBuchu
requested review from
AdRiley,
Frizi,
PabloBuchu,
farmaazon,
indiv0,
kazcw and
vitvakatu
as code owners
somebody1234
commented
Nov 4, 2025
| Week = 'Week', | ||
| Month = 'Month', | ||
| Year = 'Year', | ||
| Indefinetly = 'Indefinetly', |
There was a problem hiding this comment.
@PabloBuchu Indefinitely is the correct spelling (but maybe Indefinite is more appropriate, given that the others aren't Yearly (for example))
somebody1234
commented
Nov 4, 2025
| .min(1) | ||
| .refine((name) => !apiKeyNames.has(name), getText('duplicateApiKeyError')), | ||
| description: z.string(), | ||
| expiresIn: z.enum([ |
There was a problem hiding this comment.
z.nativeEnum(ApiKeyExpiresIn) should work
somebody1234
commented
Nov 4, 2025
| const { data: apiKeys } = useSuspenseQuery(backendQueryOptions(backend, 'listApiKeys', [])) | ||
| const apiKeyNames = new Set(apiKeys.map((apiKey) => apiKey.name)) | ||
| const createApiKey = useMutationCallback(backendMutationOptions(backend, 'createApiKey')) | ||
| const options = [ |
There was a problem hiding this comment.
i would export this alongside ApiKeyExpiresIn, in the same module as the enum itself. worth trying export const NAME_HERE = Object.values(ApiKeyExpiresIn) for example
farmaazon
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Important Notes
None
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,or the Snowflake database integration, a run of the Extra Tests has been scheduled.
If applicable, it is suggested to paste a link to a successful run of the Extra Tests.