Allow component rename on usage points #14209
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frizi
requested review from
AdRiley,
PabloBuchu,
farmaazon,
indiv0,
kazcw,
somebody1234 and
vitvakatu
as code owners
vitvakatu
reviewed
Oct 28, 2025
app/gui/src/project-view/components/GraphEditor/widgets/WidgetFunction.vue
Outdated
Show resolved
Hide resolved
app/gui/src/project-view/components/GraphEditor/widgets/WidgetFunctionDef/argumentAst.ts
Outdated
Show resolved
Hide resolved
app/gui/src/project-view/components/GraphEditor/widgets/WidgetFunctionName.vue
Outdated
Show resolved
Hide resolved
app/gui/src/project-view/components/GraphEditor/widgets/WidgetFunctionName.vue
Outdated
Show resolved
Hide resolved
app/gui/src/project-view/components/GraphEditor/widgets/WidgetFunctionName.vue
Show resolved
Hide resolved
|
|
||
| /** | ||
| * A version of vue's {@link inject} that will also inject a value provided earlier | ||
| * within the same component's setup function. |
There was a problem hiding this comment.
Oh, that’s nice. I think I needed that for… type annotation widget? (I don’t remember). Really annoying restriction on the Vue side.
vitvakatu
approved these changes
Nov 4, 2025
| return (toLowerSnakeCase(name) || 'arg') as Identifier | ||
| } | ||
|
|
||
| function toLowerSnakeCase(name: string): string { |
There was a problem hiding this comment.
We don’t have unit tests for it, do we? I suppose we should add some.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #11348
Fixes #13499