Package engine bundle #14223
Package engine bundle #14223
Conversation
4e6
added
the
CI: No changelog needed
There was a problem hiding this comment.
I'd like the description of this PR to describe the (end user) visible changes that will be achieved by this PR. Right now the description says:
Package engine bundle instead of the project manager
I can't imagine what that means!
- will this PR affect bits at this page? How?
- I see a link to this summary and
ide-linux-amd64 - in the AppImage there is no
project-manageranymore. Is that the intended change?
- I see a link to this summary and
- if so, please spell that in the description of this PR, thanks.
Update: Looks like the the change really is the project-manager binary:
$ find enso-linux-x86_64-2025.3.1-nightly.2025.10.29/ | grep project.*man
enso-linux-x86_64-2025.3.1-nightly.2025.10.29/resources/enso/bin/project-manager
there is one in yesterday's AppImage and none in the new one. Please confirm this is the only change this PR intends to do in the description of this PR.
| ); | ||
| let config = BuildConfigurationFlags { | ||
| build_project_manager_bundle: true, | ||
| build_engine_bundle: true, |
There was a problem hiding this comment.
This change removes build_project_manager_bundle and adds build_engine_bundle...
| engine-bundle-<triple>/: | ||
| ? path: enso/ | ||
| type: engine_bundle | ||
| var: engine_bundle |
There was a problem hiding this comment.
... why this change doesn't remove project-manager-bundle-<triple>? At other locations you do remove the project manager bundle invocations!
| config.build_engine_package = true; | ||
| } | ||
|
|
||
| if config.build_project_manager_bundle { |
There was a problem hiding this comment.
- at other location you can removing
buld_project_manager_bundle: true - can't you remove this whole
ifbranch? - or is there still some CI action using it?
|
@JaroslavTulach the PR is prepared in a way to minimize conflicts with the #14174 Remove project manager |
There was a problem hiding this comment.
I'm actually mostly fine with this change as it tries to distill the essentials from the PR that will do the actual removing. I like incremental steps rather than big bang changes.
If I understand correctly this PR replaces project-manager-bundle with engine-bundle. So rather than having enso-project-manager + project-manager-bundle we will have enso-engine + enso-engine-bundle (+ enso-project-manager that will be removed in a follow up PR)?
Yes, it's probably a good idea to cleanup extra artifacts. I'll try
There is a Remove project manager #14174 that removes project manager, this one just implements a proper engine bundle |
Please update the description of this issue to describe the desired state and compare it to current state. |
4e6
force-pushed
the
wip/db/package-engine-bundle-1
branch
from
ade02ae to
edd947b
Compare
4e6
force-pushed
the
wip/db/package-engine-bundle-1
branch
from
edd947b to
4fc8b15
Compare
Pull Request Description
Package engine bundle instead of the project manager
Changelog:
Important Notes
Manually checked linux Nightly Release
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.