Skip to content

Conversation

@Frizi
Copy link
Contributor

@Frizi Frizi commented Oct 29, 2025

Fixes #14096

Screencast_20251029_190822.webm
  • Implemented treating whole WidgetSelfAccessChain as additional hover area for the icon's port. That effectively "snaps" dragged edges to the icon when hovering over the method name.
  • Added debug flag to devtools that allows making all port hoverable areas visible (shown on video).
  • Simplified edge rendering to reduce complexity and help with draw performance a bit. This was provoked by an edge rendering bug that caused dragged edges to randomly get masked out when working on this feature.
    • Edge cutout mask is replaced with a clip-path that isn't shared between edges.
    • Replaced the "edge arrow" elements with stroke end marker, so the shape is shared across all edges and we have less DOM nodes to render.
    • Removed the "reversed triangle" from edges going up. All edges now have an attached arrow at the end, so it was redundant (proposed this design change to @jdunkerley and got a go-ahead).

@Frizi Frizi added the CI: No changelog needed Do not require a changelog entry for this PR. label Oct 29, 2025
Comment on lines +134 to +135
const debugHoverAreas = useFeatureFlag('debugHoverAreas')
useAppClass(() => ({ debugHoverAreas: debugHoverAreas.value }))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ProtectedLayout is a strange place for this one. I would either put it in App or in AppContainer

Copy link
Contributor Author

@Frizi Frizi Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because ProtectedLayout renders EnsoDevtools, and is effectively the closest Vue parent. This functionality is related to devtools (react), but needs to run in vue context and needs to run even when devtools are not currently displayed.

@Frizi Frizi added the CI: Ready to merge This PR is eligible for automatic merge label Nov 4, 2025
@mergify mergify bot merged commit e2c01cf into develop Nov 4, 2025
62 checks passed
@mergify mergify bot deleted the wip/frizi/port-hover-extensions branch November 4, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make component name a drop target for incoming self connections

3 participants