-
Notifications
You must be signed in to change notification settings - Fork 334
Minor upgrade to GraalVM 25.0.1 #14233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumping GraalVM version to a recently released version. Neglible impact on Native Image size.
JaroslavTulach
requested changes
Nov 4, 2025
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- all good, but please update the download link
- that's printed from
sbtwhen wrong version like 25.0.0 is used - having that link helps people download the right runtime when using only
sbt - I think the link is at
Line 238 in 340a30b
private val downloadLink = - The link is composed as
version: String = Dependencies.graalMavenPackagesVersionat https://github.com/enso-org/enso/blob/340a30bfb6c9c449c13e0b36966add51540668eb/project/GraalVM.scala#L132C46-L132C71 - Isn't that wrong? The download link shouldn't lead to
graalMavenPackagesVersion, but rathergraalVersionat https://github.com/enso-org/enso/pull/14233/files#diff-ad2642dc77b3679e4ad2c7d3b2f59a2dcf48c1bf5b93a558a4fa44828315a34cR59, I think
JaroslavTulach
approved these changes
Nov 4, 2025
Collaborator
Author
Looks alright to me
|
4e6
approved these changes
Nov 4, 2025
jdunkerley
approved these changes
Nov 4, 2025
Frizi
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Bumping GraalVM version to a recently released version. Negligible impact on Native Image size.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.