Skip to content

Conversation

@Akirathan
Copy link
Member

@Akirathan Akirathan commented Nov 3, 2025

Follow-up of #13962

Part of #11686

Pull Request Description

Builtin methods do not accept two self arguments. Remove boolean field from IR node. Decrease expected IR cache sizes.

Important Notes

  • Removed isStaticWrapperForInstanceMethod boolean field from Method.Explicit IR.
    • impact on cache sizes: reduction by 500 KB.
  • Removed isStaticInstance parameter from generated builtin method code.
    • This simplifies the generated code.
    • It used to receive two self arguments. Now, it receives a single self argument.
  • Reduce the expected IR cache size.
    • 7d906ef
    • Reduce from 130MB to 100MB.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@Akirathan Akirathan self-assigned this Nov 3, 2025
@Akirathan Akirathan added CI: No changelog needed Do not require a changelog entry for this PR. CI: Clean build required CI runners will be cleaned before and after this PR is built. labels Nov 3, 2025
@Akirathan Akirathan changed the title Remove unused BuiltinRegistry method Remove builtin methods with two self arguments Nov 3, 2025
@Akirathan Akirathan marked this pull request as ready for review November 5, 2025 09:02
@Akirathan Akirathan requested review from 4e6 and hubertp as code owners November 5, 2025 09:02
Copy link
Member

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • A lot of removed code. That's very nice!
  • The effort of #13962 seems to pay off!

@Akirathan Akirathan merged commit 8b3723a into develop Nov 5, 2025
130 of 140 checks passed
@Akirathan Akirathan deleted the wip/akirathan/remove-static-builtin-method-wrappers branch November 5, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: No changelog needed Do not require a changelog entry for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants