Single AccessManagedProxy implementation: mutable and skippable #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work in progress, first step was checking the new variant doesn't produce any impact on gas. Also, I updated solidity compiler to 0.8.30.
1. Adds IAccessManagedProxy with definitions of events emitted 2. Changes to AccessManagedProxy to match OZ's IAccessManaged as much as possible. 3. Examples in DummyImplementation of methods that changed the access_manager or the passThruMethods. 4. Additional method and test, showing custom selector checks.
LucasCambon
approved these changes
Dec 19, 2025
gnpar
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate the tested variants into a single one, for simplicity.
The AccessManagedProxy contract stores the accessManager and the skipped methods in the storage, so it can be changed. The methods for changing these values are not included in the proxy; they have to be implemented by implementation contracts.
Also included:
authority()and events and custom errors with the same names)