Major update refactoring library using Vite #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…playground also with Vite
…tore into feat/vite-esm
gnpar
reviewed
Sep 17, 2025
| { | ||
| "name": "@ensuro/api-calls-store", | ||
| "version": "%%VERSION%%", | ||
| "description": "API Calls Store for React Redux", |
gnarvaja
reviewed
Sep 17, 2025
react-playground/README.md
Outdated
| @@ -0,0 +1,12 @@ | |||
| # React + Vite | |||
|
|
|||
| This template provides a minimal setup to get React working in Vite with HMR and some ESLint rules. | |||
Contributor
There was a problem hiding this comment.
Cambiar este README, a algo relacionado con el proyecto.
react-playground/index.html
Outdated
| <meta charset="UTF-8" /> | ||
| <link rel="icon" type="image/svg+xml" href="/vite.svg" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Vite + React</title> |
Contributor
There was a problem hiding this comment.
El título de la página también, api-calls-store playground o algo así.
react-playground/src/store/index.js
Outdated
| getDefaultMiddleware({ | ||
| thunk: false, | ||
| serializableCheck: false, | ||
| immutableCheck: false, |
Contributor
There was a problem hiding this comment.
Qué son estos check? Capaz que está bueno empezar a usarlos.
src/package-index.js
Outdated
| } | ||
| getAPIFn = getAPI; | ||
| defaultCount = clockCount || 10; | ||
| if (typeof clockCount === "number") defaultCount = clockCount; |
Contributor
There was a problem hiding this comment.
if clockCount !== undefined sería más claro.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.