Change forwardToStrategy access control: strategies -> vault #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the forwardToStrategy calls where open to anyone and the strategies implemented the access control, assuming the vault was an IAccessControl. Now the strategies don't implement any access control logic, and this responsability is left to the vaults. The MultiStrategyERC4626 implements the access control by requiring two roles, one generic (FORWARD_TO_STRATEGY_ROLE) and one specific of the strategy and method being called. The AccessManagedMSV implements the access control by requiring from the access manager an authorization to call a fake method id (bytes4 selector) generated from the specific of the strategy and method being called. Also the permission to call forwardToStrategy must be granted too.
We are not using this contract in production and has known errors. It only makes sense for testing individual strategies.
Also, it uses customized deployProxy call available since OZ-upgrades 3.7.
The strategies no longer raise these kind of errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the forwardToStrategy calls where open to anyone and the strategies implemented the access control, assuming the vault was an IAccessControl.
Now the strategies don't implement any access control logic, and this responsability is left to the vaults.
The MultiStrategyERC4626 implements the access control by requiring two roles, one generic (FORWARD_TO_STRATEGY_ROLE) and one specific of the strategy and method being called.
The AccessManagedMSV implements the access control by requiring from the access manager an authorization to call a fake method id (bytes4 selector) generated from the specific of the
strategy and method being called. Also the permission to call forwardToStrategy must be granted too.