ERC4626InvestStrategy to invest in other vaults #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can be used to invest in Morpho vaults or other kind of vaults. It doesn't manage rewards or other stuff.
LucasCambon
approved these changes
May 23, 2025
| /// @inheritdoc IInvestStrategy | ||
| function forwardEntryPoint(uint8, bytes memory) external view onlyDelegCall returns (bytes memory) { | ||
| // solhint-disable-next-line gas-custom-errors,reason-string | ||
| revert(); |
Contributor
There was a problem hiding this comment.
En este caso no es mejor implementar un custom error NotImplemented() en lugar de un revert a secas?
Contributor
Author
There was a problem hiding this comment.
En varios lugares lo tenemos así, como un revert sin motivo. NotImplemented no aportaría demasiado
gnpar
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be used to invest in Morpho vaults or other kind of vaults.
It doesn't manage rewards or other stuff.