don't use trait() for extended trait names #892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronayres35
added
the
need backport to 7.3
aaronayres35
added a commit
that referenced
this pull request
Feb 22, 2021
rahulporuri
removed
the
need backport to 7.3
aaronayres35
added a commit
that referenced
this pull request
Feb 22, 2021
* don't use trait() for extended trait names (#892) * add cherry-picked PR to changelog
aaronayres35
added a commit
that referenced
this pull request
Feb 23, 2021
* don't use trait() for extended trait names (#892) * add cherry-picked PR to changelog
aaronayres35
added a commit
that referenced
this pull request
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see comment: #880 (comment)
This will need a backport before 7.3.0 is officially released!
This PR replaces
trait(_____, optional=True)with just some if statements to ensure we don't try to hook or unhook things which don't exist.