fix(review): include checkpoint context and review flow fixes#1132
fix(review): include checkpoint context and review flow fixes#1132peyton-alt wants to merge 6 commits intomainfrom
Conversation
Entire-Checkpoint: c8c88071cba4
There was a problem hiding this comment.
Pull request overview
This PR enhances entire review prompt generation by appending compact, best-effort checkpoint-derived context for commits within the detected review scope, so reviewers can reference relevant checkpoint IDs and summaries without inlining raw transcripts.
Changes:
- Add
CheckpointContextto review run configuration and append it to composed prompts (while keepingPromptOverrideverbatim). - Introduce checkpoint-context extraction for the review scope, preferring checkpoint summaries and falling back to stored prompts, with guidance to use
entire explainfor full context. - Wire the new context provider through dependency injection and add unit/smoke tests covering prompt composition and end-to-end prompt capture for a stubbed agent.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| cmd/entire/cli/review/types/reviewer.go | Extends review run configuration with checkpoint context. |
| cmd/entire/cli/review/tui_model.go | Updates nolint rationale comments for Bubble Tea interface returns. |
| cmd/entire/cli/review/prompt.go | Appends checkpoint context to generated prompts (non-override path). |
| cmd/entire/cli/review/prompt_test.go | Adds coverage ensuring checkpoint context is included and override remains verbatim. |
| cmd/entire/cli/review/cmd.go | Injects and threads checkpoint context into single- and multi-agent run configs. |
| cmd/entire/cli/review/cmd_test.go | Adjusts stub reviewer Start signature to match interface usage style. |
| cmd/entire/cli/review_context.go | Implements best-effort checkpoint context extraction for a scoped range of commits. |
| cmd/entire/cli/review_context_test.go | Adds tests for summary/prompt fallback behavior and a smoke test verifying prompt inclusion. |
| cmd/entire/cli/review_bridge.go | Wires the checkpoint-context provider into review deps from the CLI package. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 0c630e2. Configure here.
Entire-Checkpoint: fad39a003ff7
Entire-Checkpoint: 0341c011b42c
Entire-Checkpoint: d192da863bd9
Entire-Checkpoint: 41d5c4dd4836
Ensure review picker options remain visible and selected across agents. Expand Codex built-in review prompts, stream Codex assistant/tool events, and harden markdown rendering so code-block output cannot crash review dumps. Entire-Checkpoint: 80ad30770d35

https://entire.io/gh/entireio/cli/trails/312
Summary
entire reviewprompts, preferring checkpoint summaries and falling back to stored prompts without inlining raw transcripts/reviewexpands into a scoped prompt sent throughcodex exec -, and Codex assistant/tool events stream while the process is runningWhy the diff is larger than the fixes look
Tests
go test ./cmd/entire/cli/mdrender ./cmd/entire/cli/agent/codex ./cmd/entire/cli/review -count=1mise run lintmise run buildentire review --editandentire reviewverified the configured Claude Code + Codex flow, final Codex output, and no renderer panic after agents completedNote
Medium Risk
Adds dynamic, git- and checkpoint-derived context into all generated review prompts, which could affect agent behavior and relies on best-effort parsing of repo history/metadata. Risk is moderated by guardrails (scope required, truncation, no raw transcript inlining) and added tests.
Overview
Generated
entire reviewprompts now include a best-effort “checkpoint context” section derived from checkpoints found in commits within the detected branch scope.This threads a new
RunConfig.CheckpointContextthrough both single- and multi-agent paths, appends it inComposeReviewPrompt(while keepingPromptOverrideverbatim), and wires the implementation viareview_bridge.goto avoid import cycles.A new
review_context.gobuilds the compact context by scanning scoped commits forEntire-Checkpointtrailers, preferring stored checkpoint summaries and falling back to prompts, truncating detail, and pointing users toentire explain <id>for full context; tests cover prompt composition and an end-to-end smoke capture of the emitted prompt.Reviewed by Cursor Bugbot for commit 0c630e2. Configure here.