fix: point investigate/review error hints at entire agent add - #2292
Open
suhaanthayyil wants to merge 1 commit into
Open
fix: point investigate/review error hints at entire agent add#2292suhaanthayyil wants to merge 1 commit into
suhaanthayyil wants to merge 1 commit into
Conversation
…nt add` Error and status messages in `entire investigate` and `entire review` told users to run `entire configure --agent <name>`, a flag that does not exist. Agent setup lives under `entire agent add <name>`; update every hint to match and extend the corresponding tests to assert on the real message text. Fixes #2249
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The investigate error hints can still suggest an invalid entire agent add invocation (notably around the gemini-cli naming), which would mislead users into running a command that fails.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates entire investigate and entire review user-facing error hints to point to the correct agent-install command (entire agent add ...) instead of a nonexistent entire configure --agent ..., and adds/extends tests to ensure the updated hints are emitted by the real code paths.
Changes:
- Replaced stale
entire configure --agent ...guidance withentire agent add ...across investigate/review error surfaces. - Added/extended tests that exercise the real entry points and assert the hint contains
entire agent add(and notconfigure --agent).
File summaries
| File | Description |
|---|---|
| cmd/entire/cli/review/profile.go | Updates “no agents installed” error hint to use entire agent add .... |
| cmd/entire/cli/review/picker.go | Updates guided-setup and picker errors to use entire agent add .... |
| cmd/entire/cli/review/picker_test.go | Adds coverage asserting the updated hint is produced by RunReviewProfileConfigPicker. |
| cmd/entire/cli/review/picker_internal_test.go | Adds internal tests asserting updated hints for guided setup and default profile generation. |
| cmd/entire/cli/review/cmd.go | Updates list/config/runtime error output to direct users to entire agent add .... |
| cmd/entire/cli/review/cmd_test.go | Extends tests to assert entire agent add is present and configure --agent is absent. |
| cmd/entire/cli/investigate/picker.go | Updates config-picker “no eligible agents” error hint to entire agent add .... |
| cmd/entire/cli/investigate/picker_test.go | Extends test assertions to require entire agent add and reject configure --agent. |
| cmd/entire/cli/investigate/cmd.go | Updates the “hooks not installed” hint to entire agent add .... |
| cmd/entire/cli/investigate/cmd_test.go | Updates test expectations to require entire agent add and reject configure --agent. |
Review details
- Files reviewed: 10/10 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
871
to
873
| if _, ok := installedSet[name]; !ok { | ||
| return fmt.Errorf("agent %q is not launchable (run `entire configure --agent %s` first)", name, name) | ||
| return fmt.Errorf("agent %q is not launchable (run `entire agent add %s` first)", name, name) | ||
| } |
Comment on lines
142
to
146
| return nil, errors.New( | ||
| "no launchable agents with hooks installed; " + | ||
| "run `entire configure --agent <name>` for one of: " + | ||
| "run `entire agent add <name>` for one of: " + | ||
| "claude-code, codex, gemini-cli", | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://entire.io/gh/entireio/cli/trails/1242
Summary
Evidence
Test plan
Fixes #2249