This repository was archived by the owner on Nov 9, 2019. It is now read-only.
Scanner#3
Open
MilanLoveless wants to merge 19 commits intoentropic-dev:latestfrom
MilanLoveless:scanner
Open
Conversation
This parses some various imports including dynamic imports. There is probably some broken stuff, but I think it works overall.
`import` matching
|
This pull request has been mentioned on Entropic. There might be relevant details there: https://discourse.entropic.dev/t/looking-for-help-rust-based-js-import-scanner/218/47 |
MilanLoveless
commented
Jul 27, 2019
MilanLoveless
commented
Jul 27, 2019
| use ressa::Parser; | ||
| use std::vec::Vec; | ||
|
|
||
| pub fn parse_js<'a>(js: &'a str) -> Result<Vec<&'a str>, ressa::Error> { |
Author
There was a problem hiding this comment.
Should we return ressa::Error here or make our own error type/enum?
Contributor
|
Hey @MilanLoveless! I know things have been quiet for a while, but it looks like we're ramping up again. As part of that, I'm organizing our repo stuff a bit, and one of those changes is I'm going to merge the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is our first pass at the require/import scanner for this issue: https://discourse.entropic.dev/t/looking-for-help-rust-based-js-import-scanner/218
TODO: