Skip to content

Conversation

@tarcieri
Copy link
Contributor

This also includes @baloo's rand_core v0.10.0-rc-3 bump from #98.

This release switches crypto-bigint from subtle to ctutils, which seems to have surprisingly little impact on crypto-primes.

@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.93%. Comparing base (11f4735) to head (945ab35).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #104   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files          14       14           
  Lines        1893     1893           
=======================================
  Hits         1854     1854           
  Misses         39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tarcieri
Copy link
Contributor Author

I did another breaking release of ctutils (v0.3) and wanted to make sure that got reflected.

This one should be good to go, hopefully no more changes needed as I've now integrated it throughout (most of) the @RustCrypto crates

tarcieri added a commit to RustCrypto/RSA that referenced this pull request Jan 3, 2026
tarcieri added a commit to RustCrypto/RSA that referenced this pull request Jan 3, 2026
This also includes @baloo's `rand_core` v0.10.0-rc-3 bump from entropyxyz#98.

This release switches `crypto-bigint` from `subtle` to `ctutils`, which
seems to have surprisingly little impact on `crypto-primes`.
@tarcieri tarcieri force-pushed the crypto-bigint/v0.7.0-rc.13 branch from f986978 to 945ab35 Compare January 3, 2026 18:47
@fjarri fjarri merged commit 518d4d4 into entropyxyz:master Jan 3, 2026
12 checks passed
@tarcieri
Copy link
Contributor Author

tarcieri commented Jan 3, 2026

@fjarri would you mind publishing a new prerelease? It would allow us to publish new prereleases of dsa and rsa

@tarcieri tarcieri deleted the crypto-bigint/v0.7.0-rc.13 branch January 3, 2026 19:08
@fjarri
Copy link
Collaborator

fjarri commented Jan 3, 2026

I don't feel very good about releasing stuff with git dependencies that can be seen in the public API, can they use crypto-primes as a git dependency as well? Can we persuade the rand team to make a release?

@tarcieri
Copy link
Contributor Author

tarcieri commented Jan 3, 2026

@fjarri I asked about a rand release: rust-random/rand#1697 (comment)

Perhaps I'm mistaken, but since rand is under dev-dependencies I don't think it matters for the purposes of a release. Though those ultimately get listed on crates.io, really their only purpose in existing in published Cargo.toml files in crate releases is for display purposes.

If there really is a problem with sourcing a dependency from git, it should get caught in the cargo publish preflight build check, or if not that then the crates.io API itself.

@fjarri
Copy link
Collaborator

fjarri commented Jan 3, 2026

Perhaps I'm mistaken, but since rand is under dev-dependencies I don't think it matters for the purposes of a release.

Oh yes, you are right.

@fjarri
Copy link
Collaborator

fjarri commented Jan 3, 2026

Published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants