Skip to content

Bump crypto-bigint to v0.7.0-rc.22#110

Merged
fjarri merged 1 commit intoentropyxyz:masterfrom
tarcieri:crypto-bigint/v0.7.0-rc.22
Jan 25, 2026
Merged

Bump crypto-bigint to v0.7.0-rc.22#110
fjarri merged 1 commit intoentropyxyz:masterfrom
tarcieri:crypto-bigint/v0.7.0-rc.22

Conversation

@tarcieri
Copy link
Contributor

Also bumps: rand_core v0.10.0-rc-6

This release brought a few breaking changes:

  • For this crate's purposes: Unsigned => UnsignedMontyForm. I moved the associated type here, which has now been renamed MontyForm, because...
  • Monty => MontyForm: the stack-allocated type previously known as MontyForm is now known as FixedMontyForm, and the Monty trait is now MontyForm.
  • Monty(Form) methods that take a params argument now borrow: this gets rid of the params cloning that was happening before. It now clones (an Arc) for you, or copies, as need be.

Word of warning: as of this rand_core release, (Try)RngCore is now (Try)Rng. This crate wasn't impacted, however, since it uses CryptoRng which didn't change.

Also bumps: `rand_core` v0.10.0-rc-6

This release brought a few breaking changes:
- For this crate's purposes: `Unsigned` => `UnsignedMontyForm`. I moved
  the associated type here, which has now been renamed `MontyForm`,
  because...
- `Monty` => `MontyForm`: the stack-allocated type previously known as
  `MontyForm` is now known as `FixedMontyForm`, and the `Monty` trait is
  now `MontyForm`.
- `Monty(Form)` methods that take a `params` argument now borrow: this
  gets rid of the params cloning that was happening before. It now
  clones (an `Arc`) for you, or copies, as need be.

Word of warning: as of this `rand_core` release, `(Try)RngCore` is now
`(Try)Rng`. This crate wasn't impacted, however, since it uses
`CryptoRng` which didn't change.
@tarcieri
Copy link
Contributor Author

tarcieri commented Jan 24, 2026

Note: the reason for the Unsigned => UnsignedMontyForm change was if we can decouple that particular associated type from Unsigned, it means we can (potentially, with a little work) impl Unsigned for Limb. And if we can do that, we can pass Limb as a generic argument bounded on Unsigned, and have it otherwise function as a single-limb Uint/UintRef-alike.

@codecov
Copy link

codecov bot commented Jan 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.71%. Comparing base (189a0e8) to head (cdb408c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
+ Coverage   97.93%   98.71%   +0.78%     
==========================================
  Files          14       14              
  Lines        1891     1874      -17     
==========================================
- Hits         1852     1850       -2     
+ Misses         39       24      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tarcieri
Copy link
Contributor Author

@fjarri heads up, more breaking changes that could use an associated prerelease. Totally understand if you don't want to do that over the weekend though. Even having the PR/branch open is enough to unblock getting our downstream crates upgraded

@fjarri
Copy link
Collaborator

fjarri commented Jan 25, 2026

I must say, I did a double take at UnsignedMontyForm, seems like it would be better named UnsignedWithMontyForm.

@tarcieri
Copy link
Contributor Author

@fjarri sure... can we rename it after the next breaking change? I've already released a bunch of elliptic curve crates which are already dependent on this release

@fjarri
Copy link
Collaborator

fjarri commented Jan 25, 2026

No problem. I know I should have mentioned it in the respective PR, but I unfortunately wasn't following the recent squall of changes closely. I'll merge this, do you need a new release?

@fjarri fjarri merged commit ba1024f into entropyxyz:master Jan 25, 2026
12 checks passed
@tarcieri tarcieri deleted the crypto-bigint/v0.7.0-rc.22 branch January 25, 2026 00:56
@tarcieri
Copy link
Contributor Author

tarcieri commented Jan 25, 2026

@bogdan @fjarri thank you! And yes, a new release would be great!

@fjarri
Copy link
Collaborator

fjarri commented Jan 25, 2026

That's not me you're pinging :)

@tarcieri
Copy link
Contributor Author

Whoops!

@tarcieri
Copy link
Contributor Author

@fjarri also how about that release 😉

@fjarri
Copy link
Collaborator

fjarri commented Jan 25, 2026

Done.

takumi-earth pushed a commit to earthlings-dev/crypto-primes that referenced this pull request Jan 27, 2026
Also bumps: `rand_core` v0.10.0-rc-6

This release brought a few breaking changes:
- For this crate's purposes: `Unsigned` => `UnsignedMontyForm`. I moved
  the associated type here, which has now been renamed `MontyForm`,
  because...
- `Monty` => `MontyForm`: the stack-allocated type previously known as
  `MontyForm` is now known as `FixedMontyForm`, and the `Monty` trait is
  now `MontyForm`.
- `Monty(Form)` methods that take a `params` argument now borrow: this
  gets rid of the params cloning that was happening before. It now
  clones (an `Arc`) for you, or copies, as need be.

Word of warning: as of this `rand_core` release, `(Try)RngCore` is now
`(Try)Rng`. This crate wasn't impacted, however, since it uses
`CryptoRng` which didn't change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants