build: fixes multi-platform docker build #116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the multi-platform Docker build (see as an example this build only building for the current arch/platform). The main issue was that inside the docker target, the
PLATFORMS
andGOARCH_LIST
variables were set as shell variables (at target execution time), but they were expected to be Makefile variables (target definition time) by the docker target.This PR fixes it by properly defining the values as target-scoped variables, to avoid them interfering in other targets).
Before:
After: