e2e: ensures the route recalculated #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
mathetake
commented
Jan 20, 2025
Comment on lines
-62
to
-63
| mutation_rules: | ||
| allow_all_routing: true |
There was a problem hiding this comment.
this was unneeded and makes the configuration diff between EG and raw envoy here smaller
yuzisun
reviewed
Jan 20, 2025
api/v1alpha1/api.go
Outdated
| @@ -61,7 +61,7 @@ type AIGatewayRouteSpec struct { | |||
| // modifications to achieve the necessary jobs, notably inserting the AI Gateway filter responsible for | |||
| // the transformation of the request and response, etc. | |||
| // | |||
| // In the matching conditions in the AIGatewayRouteRule, `x-envoy-ai-gateway-model` header is available | |||
| // In the matching conditions in the AIGatewayRouteRule, `x-eaig-model` header is available | |||
There was a problem hiding this comment.
tbh, eaig looks like a typo unfortunately, suggest x-ai-eg-model which reads better?
There was a problem hiding this comment.
let's stick to ai-eg-* from now!
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
aabchoo
added a commit
that referenced
this pull request
Jan 21, 2025
Previously, internally `x-envoy-ai-gateway-selected-backend` was used for routing. However, it has some conflicts with the EG default setting named `suprressEnvoyHeaders: true` and that caused the route recalculation ignored. This fixes it. In general, we shouldn't use the Envoy internal headers x-envoy-* for headers we generate in this project. Thanks @yuzisun for finding this out. --------- Signed-off-by: Takeshi Yoneda <[email protected]> Signed-off-by: Aaron Choo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, internally
x-envoy-ai-gateway-selected-backendwas used for routing. However, it has some conflicts with the
EG default setting named
suprressEnvoyHeaders: trueandthat caused the route recalculation ignored. This fixes it.
In general, we shouldn't use the Envoy internal headers
x-envoy-* for headers we generate in this project.
Thanks @yuzisun for finding this out.