extproc: fix filter config marshalling #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ignasi Barrera <[email protected]>
nacx
changed the title
|
If we use json tags, shall we reuse the types defined from the control plane API? I feel like we are duplicating the types and it is hard to maintain going forward. |
|
Re: reusing - that's intentional and this is to decouple EG specific doc comment etc. for example backend here is a mere string vs the real Backend resource. If this gets really hard to maintain let's switch back to it, but for now let me take care of it:🙇 |
aabchoo
added a commit
that referenced
this pull request
Jan 21, 2025
Signed-off-by: Aaron Choo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The YAML library being used does not honor the
yamltags. It just considers thejsonones and the extproc filter config was not unmarshaleld according to the defined values.The
llmRequestCosts.metadataKeyandMetadataNamespaceproperties had wrong tags.