feat: implements CEL expression API for costs #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
|
@yuzisun PTAL |
Signed-off-by: Takeshi Yoneda <[email protected]>
mathetake
commented
Jan 21, 2025
mathetake
commented
Jan 21, 2025
Comment on lines
-28
to
+30
| ModelNameHeaderKey, selectedBackendHeaderKey string | ||
| modelNameHeaderKey, selectedBackendHeaderKey string |
There was a problem hiding this comment.
note: shouldn't have been exported
nacx
reviewed
Jan 21, 2025
| p.costs.TotalTokens, | ||
| ) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to evaluate CEL expression: %w", err) |
There was a problem hiding this comment.
Out of curiosity, what does it mean for ext_proc to fail at this stage, when the response headers may have been sent? Does it make sense to make it fail?
There was a problem hiding this comment.
this will result in connection termination i guess
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the CEL expression API
left as a TODO in #103. Closes #97.