-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[redis_proxy] Allow Multi-Key Commands in Redis Transactions #37982
Conversation
Signed-off-by: Diogo Barbosa <[email protected]>
Signed-off-by: Diogo Barbosa <[email protected]>
Signed-off-by: Diogo Barbosa <[email protected]>
Signed-off-by: Diogo Barbosa <[email protected]>
Signed-off-by: Diogo Barbosa <[email protected]>
/assign @weisisea as codeowner, I'm not familiar enough with redis. @dbarbosapn this needs a main merge for changelog. |
Signed-off-by: Diogo Barbosa <[email protected]>
Signed-off-by: Diogo Barbosa <[email protected]>
needs main merge. @dbarbosapn re your recent force-push, please read https://github.com/envoyproxy/envoy/blob/main/CONTRIBUTING.md and in particular the section https://github.com/envoyproxy/envoy/blob/main/CONTRIBUTING.md and this bullet:
/wait |
It was to fix DCO 😄 I fixed changelog conflicts using the GitHub UI, it said "Sign Off and Commit", commit showed verified but DCO was claiming it was not, it was red 😄 So I had to rebase unfortunately I don't know if it's because I enabled the beta merge experience UI 🤔 |
Signed-off-by: Diogo Barbosa <[email protected]>
Hey @mattklein123 , @weisisea kind ping 🙇 |
LGTM please merge main. /wait |
Signed-off-by: Diogo Barbosa <[email protected]>
Done. Thanks @mattklein123 🙇 |
…oxy#37982) There's no functional difference currently in allowing multi-key commands to go through in Redis transactions. The way this will work is that they're sent to the server of the first key, and this server will handle any cross-slot errors, by returning `ERR MOVED` or `ERR CROSSSLOT`. This PR fixes this gap which will allow Envoy customers to use `DEL` among other important commands within transactions. Documentation was also updated, to reflect this and past changes (a miss from my side on previous PR, sorry 😛) Risk Level: Low Testing: ✅ Release Notes: ✅ Docs changes: ✅ Execution sample:  --------- Signed-off-by: Diogo Barbosa <[email protected]>
There's no functional difference currently in allowing multi-key commands to go through in Redis transactions. The way this will work is that they're sent to the server of the first key, and this server will handle any cross-slot errors, by returning
ERR MOVED
orERR CROSSSLOT
.This PR fixes this gap which will allow Envoy customers to use
DEL
among other important commands within transactions.Documentation was also updated, to reflect this and past changes (a miss from my side on previous PR, sorry 😛)
Risk Level: Low
Testing: ✅
Release Notes: ✅
Docs changes: ✅
Execution sample: