tools/deprecate_guards: Fix error handling #38006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlax
commented
Jan 14, 2025
| @@ -180,7 +180,7 @@ async def create_issue(self, title: str, body: str, login: str) -> None: | |||
| else: | |||
| self.log.warning(f"Dry run: not creating issue '{title}' for {login}") | |||
| return | |||
| except gidgethub.Exception: | |||
| except gidgethub.GithubException: | |||
There was a problem hiding this comment.
Suggested change
| except gidgethub.GithubException: | |
| except gidgethub.GitHubException: |
argh - if we shift this to toolshed we can test properly
Signed-off-by: Ryan Northey <[email protected]>
phlax
force-pushed
the
tools-guards-exception
branch
from
2952d08 to
7d7c3ad
Compare
alyssawilk
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.