Skip to content

Comments

(http/mcp) Add options to extract trace context & baggage from mcp params._meta#43561

Open
antoniovleonti wants to merge 5 commits intoenvoyproxy:mainfrom
antoniovleonti:mcp-trace-headers
Open

(http/mcp) Add options to extract trace context & baggage from mcp params._meta#43561
antoniovleonti wants to merge 5 commits intoenvoyproxy:mainfrom
antoniovleonti:mcp-trace-headers

Conversation

@antoniovleonti
Copy link
Contributor

Commit Message: (http/mcp) Add options to extract trace context & baggage from mcp params._meta
Additional Description:

add options extract_trace_context and extract_baggage to http mcp filter

Risk Level: low
Testing: unit & integration tested
Docs Changes: none
Release Notes: added

Signed-off-by: antoniovleonti <[email protected]>
Signed-off-by: antoniovleonti <[email protected]>
@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @adisuissa
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #43561 was opened by antoniovleonti.

see: more, trace.

Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
High-level question, and comment:

  • Will it make sense to add these as part of separate message type? (not an AI, just wondering)
  • By reading the API I don't fully understand how these impact a user that configures these config knobs. It would help to think of it from the perspective of an Envoy operator - if they set these flags, what do they expect to see?

Signed-off-by: antoniovleonti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants