Fix CoreAudio DLL path not being found (on newer Wine?) - #15
Open
udf wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FindFirstFile considers a path with a trailing backslash as invalid:
It seems the trailing backslash used to be fine on older versions of Wine, but it has since been fixed.
This could be resolved by trimming the backslash, but I think it's better to use PathFileExists instead, which "Determines whether a path to a file system object such as a file or folder is valid.".
I have not tested the changes on Windows, however (but if the Microsoft Documentation is to be believed then it shouldn't have worked before).