Respect ClearAlbumArtist setting when reading cue sheets - #23
Open
ElCruncharino wants to merge 1 commit into
Open
Respect ClearAlbumArtist setting when reading cue sheets#23ElCruncharino wants to merge 1 commit into
ElCruncharino wants to merge 1 commit into
Conversation
The cue sheet reader always withheld the album artist tag whenever it matched the track artist, regardless of the TagEdit ClearAlbumArtist setting, which is meant to make that behavior opt-in. Gate it on the setting like the tag editor's own album chooser already does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cue sheet reader always withheld the album artist tag whenever it
matched the track artist, regardless of the TagEdit ClearAlbumArtist
setting, which is meant to make that behavior opt-in. Gate it on the
setting the same way the tag editor's album chooser already does.
Closes #559