refactor(data): Make json branches consistent

Cherry pick of c07249c (assert-rs#287)
epage · May 15, 2024 · 2a1d5a4 · 2a1d5a4
1 parent d19b177
commit 2a1d5a4
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/crates/snapbox/src/data/mod.rs b/crates/snapbox/src/data/mod.rs
@@ -338,9 +338,10 @@ impl Data {
             }
             #[cfg(feature = "json")]
             (DataInner::Text(inner), DataFormat::Json) => {
-                match serde_json::from_str::<serde_json::Value>(&inner) {
-                    Ok(json) => Self::json(json),
-                    Err(_) => Self::text(inner),
+                if let Ok(json) = serde_json::from_str::<serde_json::Value>(&inner) {
+                    Self::json(json)
+                } else {
+                    Self::text(inner)
                 }
             }
             #[cfg(feature = "term-svg")]