Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added option groups; updated deps; clippy #463

Merged
merged 3 commits into from
Jan 16, 2022
Merged

Conversation

epi052
Copy link
Owner

@epi052 epi052 commented Jan 15, 2022

closes #112

Landing a Pull Request (PR)

Long form explanations of most of the items below can be found in the CONTRIBUTING guide.

Branching checklist

  • There is an issue associated with your PR (bug, feature, etc.. if not, create one)
  • Your PR description references the associated issue (i.e. fixes #123456)
  • Code is in its own branch
  • Branch name is related to the PR contents
  • PR targets main

Static analysis checks

  • All rust files are formatted using cargo fmt
  • All clippy checks pass when running cargo clippy --all-targets --all-features -- -D warnings -A clippy::mutex-atomic
  • All existing tests pass

Documentation

  • New code is documented using doc comments
  • Documentation about your PR is included in the README, as needed

Additional Tests

  • New code is unit tested
  • New code is integration tested, as needed
  • New tests pass

@codecov
Copy link

codecov bot commented Jan 16, 2022

Codecov Report

Merging #463 (e5048f0) into main (b87836f) will decrease coverage by 0.01%.
The diff coverage is 97.32%.

❗ Current head e5048f0 differs from pull request most recent head 1500e65. Consider uploading reports for the commit 1500e65 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #463      +/-   ##
==========================================
- Coverage   94.90%   94.89%   -0.02%     
==========================================
  Files          58       58              
  Lines        6618     6641      +23     
==========================================
+ Hits         6281     6302      +21     
- Misses        337      339       +2     
Impacted Files Coverage Δ
src/banner/container.rs 98.49% <50.00%> (+<0.01%) ⬆️
src/config/container.rs 94.64% <100.00%> (ø)
src/parser.rs 100.00% <100.00%> (ø)
src/scan_manager/tests.rs 97.94% <0.00%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b87836f...1500e65. Read the comment docs.

@epi052 epi052 merged commit 7cf834d into main Jan 16, 2022
@epi052 epi052 deleted the 112-parser-option-groups branch January 16, 2022 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Option Groups to parser
1 participant