nt/common: fix Python-2 _dt2posix using * instead of + for microseconds#216
Open
jacquelinegarrahan wants to merge 1 commit into
Open
nt/common: fix Python-2 _dt2posix using * instead of + for microseconds#216jacquelinegarrahan wants to merge 1 commit into
jacquelinegarrahan wants to merge 1 commit into
Conversation
The py2 fallback computed `_timegm(dt.timetuple()) * dt.microsecond*1e-6`, multiplying the epoch seconds by the fractional part (and yielding 0 whenever microsecond==0) instead of adding the sub-second offset. Only reachable on Python 2 (py3 uses datetime.timestamp), but the result there was grossly wrong. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The py2 fallback computed
_timegm(dt.timetuple()) * dt.microsecond*1e-6,multiplying the epoch seconds by the fractional part (and yielding 0 whenever
microsecond==0) instead of adding the sub-second offset. Only reachable on
Python 2 (py3 uses datetime.timestamp), but the result there was grossly
wrong.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com