asLib/pvlist: fix AssertionError on ALLOW rule containing a capture group#220
Open
jacquelinegarrahan wants to merge 1 commit into
Open
Conversation
…roup The ALLOW branch advanced `ngroups` by 1 (for the wrapper group that _re_join adds) but, unlike the ALIAS branch, never added the pattern's own capture-group count `C.groups`. The final invariant `assert self._allow_pat.groups+1==ngroups` then failed for any ALLOW pattern with a capture group (e.g. `.*(foo|bar).* ALLOW`), aborting the whole pvlist load and taking the gateway down via readnproc -> sys.exit(1). It also left the per-rule group indices in `_allow_groups` misaligned for subsequent rules. Mirror the ALIAS branch by adding `ngroups += C.groups`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ALLOW branch advanced
ngroupsby 1 (for the wrapper group that_re_join adds) but, unlike the ALIAS branch, never added the pattern's own
capture-group count
C.groups. The final invariantassert self._allow_pat.groups+1==ngroupsthen failed for any ALLOW patternwith a capture group (e.g.
.*(foo|bar).* ALLOW), aborting the whole pvlistload and taking the gateway down via readnproc -> sys.exit(1). It also left
the per-rule group indices in
_allow_groupsmisaligned for subsequent rules.Mirror the ALIAS branch by adding
ngroups += C.groups.Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com