client/thread: fix multi-PV get()/put() reporting timeout against wrong PV#223
Open
jacquelinegarrahan wants to merge 1 commit into
Open
Conversation
…ng PV The timeout branch of the collection loop wrote result[i]/name[i] using the loop variable `i`, which after `value, i = done.get(...)` holds the index of the last PV that *succeeded* (or the leftover enumerate index if none had). Because `done` is a single shared queue, this reported the timeout against the wrong PV: a fast PV's good value was overwritten with a TimeoutError while the PV that actually timed out was returned as None (or, with throw=True, the raised TimeoutError named the wrong PV). Track the set of outstanding indices explicitly and, on timeout, mark every still-pending PV. The same bug and fix apply to both get() and put(). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jul 15, 2026
client/thread: fix multi-PV get()/put() reporting timeout against wrong PV
jacquelinegarrahan/p4p#10
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The timeout branch of the collection loop wrote result[i]/name[i] using the
loop variable
i, which aftervalue, i = done.get(...)holds the index ofthe last PV that succeeded (or the leftover enumerate index if none had).
Because
doneis a single shared queue, this reported the timeout against thewrong PV: a fast PV's good value was overwritten with a TimeoutError while the
PV that actually timed out was returned as None (or, with throw=True, the
raised TimeoutError named the wrong PV).
Track the set of outstanding indices explicitly and, on timeout, mark every
still-pending PV. The same bug and fix apply to both get() and put().
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com