fix(a11y): fix issues from the a11y report #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update snapshots to include focus guards and aria attributes for improved accessibility
kblounas
requested changes
Feb 10, 2025
kblounas
reviewed
Feb 10, 2025
lkatmadas
reviewed
Feb 10, 2025
src/components/Tabs/Tabs.tsx
Outdated
| @@ -120,6 +121,15 @@ const Tabs: FC<TabsProps> = ({ | |||
| } | |||
| }; | |||
|
|
|||
| // Update document title with the selected tab title for a11y purposes | |||
| useEffect(() => { | |||
| const tempBaseTitle = document.title; | |||
There was a problem hiding this comment.
We can directly use document.title instead of storing it in a temporary variable
src/components/Tabs/Tabs.tsx
Outdated
| if (!baseTitle) setBaseTitle(tempBaseTitle); | ||
| const selectedTab = tabs[activeTab]; | ||
| const tabTitle = typeof selectedTab?.title === "string" ? selectedTab.title : ""; | ||
| document.title = tabTitle ? `${baseTitle} | ${tabTitle}` : baseTitle; |
There was a problem hiding this comment.
This updates document.title on every render, even if the title hasn't changed. I think something like this would work:
const newTitle = tabTitle ? `${baseTitle} | ${tabTitle}` : baseTitle;
if (document.title !== newTitle) {
document.title = newTitle;
}
kblounas
reviewed
Feb 11, 2025
| @@ -109,6 +109,7 @@ | |||
| "core-js": "^3.38.1", | |||
| "deepmerge": "^4.3.1", | |||
| "framer-motion": "^6.5.1", | |||
| "react-focus-lock": "^2.13.5", | |||
There was a problem hiding this comment.
better lock package version
Comment on lines
+125
to
+129
| useEffect(() => { | ||
| return () => { | ||
| document.title = baseTitleRef.current; | ||
| }; | ||
| }, []); |
There was a problem hiding this comment.
no need for return keyword
useEffect(() => () => {
document.title = baseTitleRef.current;
}}, []);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.3.2 -> Modal.tsx
6.4.1 -> Tabs.tsx
6.5.1 -> Drawer.tsx, package.json (added react-focus-lock)
6.11.1 -> ToggleSwitch.tsx
6.12.1 -> Tooltip.tsx