Task: Release Candidate 2.0.4 #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ensures that logging always happens with the appropriate severity depending on the exception status - reduces the types of errors that can trigger a an error metric and therefore a notification in slack (e.g. :bad_request is set at WARN level and therefore not alerted on, whereas :internal_server_error is set at ERROR level and does trigger alerts
- removes bundle restrictions from `assets` target - removes `assets` and `start` target calls from `server` target in favour of passing via command line - removes `local` target to maintain makefile conformity across projects
Task: Improved Logging
- Removed old git reference for the qonsole_rails gem. - Added the qonsole_rails gem to the source block instead. - Updated several gems to their latest versions. - Cleaned up commented-out paths in the Gemfile.
Task: Load Qonsole Rails as a gem
Made the version string immutable by freezing it. This helps prevent accidental modifications and improves performance.
- Added the metrics plugin for Puma as now using Rails 6 or greater - Set up a configurable metrics port with a default value. - Updated the binding URL for the metrics server in development.
- Changed the way boot information is printed. - Switched to JSON format for better compatibility with logging services. - Refactored method to improve clarity and structure.
- Included `puma-metrics` gem for better monitoring - Updated Gemfile and Gemfile.lock to reflect the addition
- Changed boot info printing method - Switched to JSON format for logging compatibility - Refactored method for better clarity - Made version string immutable - Added `puma-metrics` gem for monitoring with Rails 6+ - Updated Gemfile and Gemfile.lock accordingly - Configurable metrics port set up with a default value - Updated metrics server binding URL in development - Removed old git reference and added new gem source block - Updated several gems to latest versions
Task: Startup and shutdown logs now json
Updated the logging mechanism for Rails startup messages to output in JSON format. Removed redundant code and ensured compatibility with combined logging services.
- Added log level setting based on environment variable. - Default to 'debug' in development and 'info' in production/test.
- Added log level configuration based on environment. - Default log levels set to 'debug' for development and 'info' for production/test. - Improved boot information printing and switched to JSON format for logging.
Issue: 63 Logging issues
jonrandahl
requested review from
bogdanadrianmarc,
joescottdave and
DanielCouzens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings all the current updates onto the preprod instance for verification before release to live.