Spike: Resolve updated package requirements #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regenerated Gemfile.lock to ensure compatibility with the latest Data Services API Gem. This also bumped major versions for several gems, including actioncable, actionmailbox, and rails. Other minor updates include improvements in various libraries like nokogiri and rubocop.
- Added deprecation warning for `to_time` behaviour change - Set `to_time_preserves_timezone` to preserve system timezone
Switched the logo link to use `link_to` for better readability and maintainability. This change also ensures that the path is generated correctly with the current locale.
Switched from `require: rubocop-rails` to `plugins: rubocop-rails` in the configuration. This aligns with the latest extension support.
- Changed flash message to use `flash.now` for immediate display. - Updated several methods to simplify block passing syntax. - Replaced `puts` with `Rails.logger.debug` for better logging practices. - Cleaned up some method definitions by removing unnecessary comments and rubocop directives. - Adjusted environment configurations for improved clarity.
Updated the constant initialization to avoid warnings. Changed from a conditional assignment to a direct assignment for better clarity and performance.
- Added comments to disable RuboCop metrics warnings - Cleaned up module and class definitions for clarity - Improved method organization in presenters
Cleaned up the code by removing the 'set' library import since it wasn't being used. This helps keep things tidy and improves readability.
- Added a deprecation warning for `to_time` behavior change - Set `to_time_preserves_timezone` to preserve system timezone - Applied recommended linting corrections from Rubocop
jonrandahl
requested review from
joescottdave,
bogdanadrianmarc and
DanielCouzens
- Updated test classes to use consistent formatting. - Replaced `I18n.locale` with `I18n.with_locale` for better context handling. - Cleaned up commented-out test methods across various test files. - Added documentation comments where necessary for clarity.
- Added a raise statement after logging date parse errors - Ensures that the error propagates up for better handling
- Changed instance variable assignment to use ||= for params - Updated class comment to disable a style check for length - No functional changes, just cleaning up the code a bit
- Made json initialization more robust - Added rubocop disables for method complexity warnings - Cleaned up task descriptions for better readability
- Added I18n support - Updated test cases to check for invalid date formats - Changed 'from' and 'to' date values in tests to reflect invalid scenarios
- Changed how test files are identified. - Simplified the command to run tests using `make`. - Removed system test execution from the hook. - Improved feedback on push failure due to failing tests.
- Replaced 'capybara_minitest_spec' with 'capybara' - Added 'minitest-rails-capybara' for enhanced testing - Updated Gemfile.lock to reflect these changes
Improve error handling and testing setup: - Added error raising for date parsing failures, logging errors. - Updated the test suite to follow rubocop linting suggestions. - Simplified pre-push githook to run a single `make test` command. - Included deprecation warning for `to_time` behavior change.
Replaced Rails logger debug statements with puts for better visibility in development. This affects various commands and setup scripts, ensuring that important messages are printed directly to the console instead of being logged.
Updated the patch version from 1 to 2 for this set of changes.
- Updated version number in changelog to reflect latest changes in appropriate section
- Added error handling for date parsing failures - Improved test suite with rubocop suggestions - Simplified pre-push githook to use a single command - Changed time measurement from microseconds to milliseconds - Removed duplicate gem entry - Updated rails gem and dependencies to v8.0.1 - Added dynamic `LOG_LEVEL` environment variable - Enhanced Sentry logging for Rails and VUE/JS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR primarily contains a regenerated Gemfile.lock to ensure compatibility with the latest Data Services API Gem.
This also bumped major versions for several gems, including actioncable, actionmailbox, and rails to v8.0.1
Other minor updates include improvements in various libraries like nokogiri and rubocop.
Additional changes
to_timebehaviour changeto_time_preserves_timezoneto preserve system timezone