-
Notifications
You must be signed in to change notification settings - Fork 4
use epicontacts::get_degree()
to replace wrangling steps from epicontacts
to fitdistrplus
#169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/epiverse-trace/tutorials-middle/compare/md-outputs..md-outputs-PR-169 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2025-05-01 21:04:42 +0000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor edits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @avallecam! I read through the .Rmd
file changes and everything looks good. I've left a few comments on the file. I haven't rendered the tutorial to see how it looks as a web page but happy to take a look once this is merged and live and I'll open an issue if I spot anything that needs changing/fixing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @joshwlambert. Could you take a look at the edits in response to your questions?
@avallecam I've read through the responses and all of your proposed updates look good to me. I don't have any further comments so please feel free to merge when you're ready. Nice work on putting this together; I think this comprehensively covers the discussions we had around epiverse-trace/superspreading#121. |
- simply the epicontacts to fitdistrplus connection - use only_linelist = TRUE for cases without infectees - edit some text to facilitate readability
Co-authored-by: Joshua Lambert <[email protected]>
79c1903
to
0526a28
Compare
This aims to simply the
epicontacts
tofitdistrplus
connection, as discussed in epiverse-trace/superspreading#121 (comment)Also, fix #170 to use
only_linelist = TRUE
to count the secondary cases from observed infections without onward transmission (infectees).This also edits some text to define graph concepts and facilitate readability in unrelated sections.
Update:
Fix #184