Skip to content

use epicontacts::get_degree() to replace wrangling steps from epicontacts to fitdistrplus #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 1, 2025

Conversation

avallecam
Copy link
Member

@avallecam avallecam commented Apr 3, 2025

This aims to simply the epicontacts to fitdistrplus connection, as discussed in epiverse-trace/superspreading#121 (comment)

Also, fix #170 to use only_linelist = TRUE to count the secondary cases from observed infections without onward transmission (infectees).

This also edits some text to define graph concepts and facilitate readability in unrelated sections.


Update:

Fix #184

Copy link

github-actions bot commented Apr 3, 2025

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/epiverse-trace/tutorials-middle/compare/md-outputs..md-outputs-PR-169

The following changes were observed in the rendered markdown documents:

 ...eading-estimate-rendered-unnamed-chunk-10-1.png | Bin 17026 -> 9096 bytes
 ...-estimate-rendered-unnamed-chunk-13-1.png (new) | Bin 0 -> 19283 bytes
 ...reading-estimate-rendered-unnamed-chunk-4-1.png | Bin 6053403 -> 5983697 bytes
 ...g-estimate-rendered-unnamed-chunk-8-1.png (new) | Bin 0 -> 9426 bytes
 ...reading-estimate-rendered-unnamed-chunk-9-1.png | Bin 9426 -> 17026 bytes
 md5sum.txt                                         |   2 +-
 network.html                                       |   6 +-
 superspreading-estimate.md                         | 183 ++++++++++++++-------
 webshot.png                                        | Bin 6053403 -> 5983697 bytes
 9 files changed, 125 insertions(+), 66 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2025-05-01 21:04:42 +0000

github-actions bot pushed a commit that referenced this pull request Apr 3, 2025
github-actions bot pushed a commit that referenced this pull request Apr 3, 2025
github-actions bot pushed a commit that referenced this pull request Apr 3, 2025
@avallecam avallecam mentioned this pull request Apr 3, 2025
15 tasks
github-actions bot pushed a commit that referenced this pull request Apr 3, 2025
Copy link
Member Author

@avallecam avallecam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor edits

@avallecam avallecam requested a review from joshwlambert April 3, 2025 19:43
github-actions bot pushed a commit that referenced this pull request Apr 3, 2025
@avallecam avallecam marked this pull request as ready for review April 3, 2025 20:40
Copy link
Member

@joshwlambert joshwlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @avallecam! I read through the .Rmd file changes and everything looks good. I've left a few comments on the file. I haven't rendered the tutorial to see how it looks as a web page but happy to take a look once this is merged and live and I'll open an issue if I spot anything that needs changing/fixing.

github-actions bot pushed a commit that referenced this pull request Apr 8, 2025
Copy link
Member Author

@avallecam avallecam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @joshwlambert. Could you take a look at the edits in response to your questions?

@joshwlambert
Copy link
Member

@avallecam I've read through the responses and all of your proposed updates look good to me. I don't have any further comments so please feel free to merge when you're ready.

Nice work on putting this together; I think this comprehensively covers the discussions we had around epiverse-trace/superspreading#121.

github-actions bot pushed a commit that referenced this pull request May 1, 2025
github-actions bot pushed a commit that referenced this pull request May 1, 2025
github-actions bot pushed a commit that referenced this pull request May 1, 2025
avallecam and others added 7 commits May 1, 2025 16:01
- simply the epicontacts to fitdistrplus connection
- use only_linelist = TRUE  for cases without infectees
- edit some text to facilitate readability
Co-authored-by: Joshua Lambert <[email protected]>
@avallecam avallecam force-pushed the fix-epicontacts-fitdistrplus branch from 79c1903 to 0526a28 Compare May 1, 2025 21:01
github-actions bot pushed a commit that referenced this pull request May 1, 2025
@avallecam avallecam merged commit c9eb08c into main May 1, 2025
6 checks passed
@avallecam avallecam deleted the fix-epicontacts-fitdistrplus branch May 1, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add reprex code on only linelist FALSE or TRUE as callout box use only_linelist = TRUE at epicontacts::get_degree()
2 participants