Skip to content

Conversation

Bisaloo
Copy link
Member

@Bisaloo Bisaloo commented May 5, 2025

This is @avallecam speaking:

Dear reviewers, thank you for nominating yourself to review the automatic translation of episodes:

The translated files are accessible in the "Files changed" tab of this PR. Find the Rmd file that corresponds to your assigned episode. Then, click on Load diff.

Find quick links to these that we need with priority:

We are open to accepting your specific changes to one or multiple lines using the "Files changed" tab. To start your review, you can follow steps 5 to 8 from this how-to guide on Reviewing proposed changes in a pull request. Using this method, your line comments are pending and only visible to you. Press Submit Review when finished.

If you prefer an alternative method for review, please let me know, and we can coordinate another platform according to your needs. Each episode could be reviewed on different platforms.

Lastly, we mostly want your review of the French translation of the text only. If you have a thematic or technical improvement you would like the tutorials to have, please feel free to fill an issue. We encourage you to focus on the written content only.

Copy link

github-actions bot commented May 5, 2025

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/epiverse-trace/tutorials-middle/compare/md-outputs..md-outputs-PR-187

The following changes were observed in the rendered markdown documents:

 config.yaml (gone)                                 |   86 -
 create-forecast.md                                 |   59 +-
 delays-functions.md                                |   34 +-
 ...create-forecast-rendered-unnamed-chunk-10-1.png |  Bin 9592 -> 9592 bytes
 ...create-forecast-rendered-unnamed-chunk-12-1.png |  Bin 8571 -> 8430 bytes
 fig/create-forecast-rendered-unnamed-chunk-4-1.png |  Bin 46451 -> 46599 bytes
 ...unctions-rendered-unnamed-chunk-13-1.png (gone) |  Bin 5088 -> 0 bytes
 ...unctions-rendered-unnamed-chunk-16-1.png (gone) |  Bin 50215 -> 0 bytes
 ...elays-functions-rendered-unnamed-chunk-19-1.png |  Bin 51649 -> 50722 bytes
 ...unctions-rendered-unnamed-chunk-20-1.png (gone) |  Bin 30533 -> 0 bytes
 ...unctions-rendered-unnamed-chunk-21-1.png (gone) |  Bin 30140 -> 0 bytes
 ...elays-functions-rendered-unnamed-chunk-22-1.png |  Bin 52084 -> 52054 bytes
 ...elays-functions-rendered-unnamed-chunk-23-1.png |  Bin 30731 -> 30830 bytes
 ...ransmissibility-rendered-unnamed-chunk-10-1.png |  Bin 62183 -> 61606 bytes
 ...sibility-rendered-unnamed-chunk-17-1.png (gone) |  Bin 28343 -> 0 bytes
 ...sibility-rendered-unnamed-chunk-18-1.png (gone) |  Bin 32514 -> 0 bytes
 ...ransmissibility-rendered-unnamed-chunk-19-1.png |  Bin 28828 -> 28826 bytes
 ...ransmissibility-rendered-unnamed-chunk-20-1.png |  Bin 32358 -> 31664 bytes
 ...ssibility-rendered-unnamed-chunk-9-1.png (gone) |  Bin 9543 -> 0 bytes
 ...everity-static-rendered-unnamed-chunk-11-1.png} |  Bin
 ...everity-static-rendered-unnamed-chunk-22-1.png} |  Bin
 ...severity-static-rendered-unnamed-chunk-3-1.png} |  Bin
 ...reading-estimate-rendered-unnamed-chunk-4-1.png |  Bin 5012331 -> 7086477 bytes
 md5sum.txt                                         |   36 +-
 network.html                                       |    6 +-
 quantify-transmissibility.md                       |   83 +-
 renv.lock (gone)                                   | 6172 --------------------
 severity-static.md                                 |   96 +-
 webshot.png                                        |  Bin 5012331 -> 7086477 bytes
 29 files changed, 161 insertions(+), 6411 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2025-10-13 19:49:12 +0000

github-actions bot pushed a commit that referenced this pull request May 5, 2025
github-actions bot pushed a commit that referenced this pull request Sep 16, 2025
Copy link
Member

@avallecam avallecam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding to minor edits for consistency

github-actions bot pushed a commit that referenced this pull request Sep 24, 2025
Comment on lines 72 to 77
# installer les packages si elles ne le sont pas déjà
if (!require("pak")) install.packages("pak")
if (!require("cfr")) pak::pak("cfr")
if (!require("epiparameter")) pak::pak("epiparameter")
if (!require("tidyverse")) pak::pak("tidyverse")
if (!require("outbreaks")) pak::pak("outbreaks")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Karim-Mane, thanks for this suggestion across your reviews. From deliveries, we have learned that having this script is useful indeed. I have two notes:

  • when using {pak} it is not required to use if(!require()) given that {pak} actually have this feedback-loop embeded. So if it is installed, it assesses the version difference. and ask the user.
  • Some packages require more prereq in case the installation does not work, for that reason we prioritize installation from the main setup page.

So, in order to have this in consideration, let's opt to have it as a spoiler callout (the one that can be collapsed.) This will include a link to the main setup page, where learners will read how to troubleshoot any particular error, and keep that resource centralized, in a way, and do not replicate steps across tutorial pages.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did these edits: 58d71ef and 0af94b8

github-actions bot pushed a commit that referenced this pull request Oct 13, 2025
github-actions bot pushed a commit that referenced this pull request Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants