Continue cleanups post removing HDFS from Solr

[Copilot]

Consolidate abstract test base classes that have only one subclass by merging them into their concrete test classes. Removes obsolete HDFS contrib references and cleans up HDFS-specific code.

Description

Abstract test classes in org.apache.solr.cloud that existed solely to support HDFS contrib (now removed) have been merged into their single concrete subclasses. Additionally, HDFS-specific references in production code have been cleaned up.

Solution

Merged 13 abstract classes into concrete tests:

• AbstractRestartWhileUpdatingTestBase → RestartWhileUpdatingTest
• AbstractBasicDistributedZk2TestBase → BasicDistributedZk2Test
• AbstractBasicDistributedZkTestBase → BasicDistributedZkTest
• AbstractChaosMonkeyNothingIsSafeTestBase → ChaosMonkeyNothingIsSafeTest
• AbstractChaosMonkeySafeLeaderTestBase → ChaosMonkeySafeLeaderTest
• AbstractDigestZkACLAndCredentialsProvidersTestBase → VMParamsZkACLAndCredentialsProvidersTest
• AbstractMoveReplicaTestBase → MoveReplicaTest
• AbstractRecoveryZkTestBase → RecoveryZkTest
• AbstractSyncSliceTestBase → SyncSliceTest
• AbstractTlogReplayBufferedWhileIndexingTestBase → TlogReplayBufferedWhileIndexingTest
• AbstractUnloadDistributedZkTestBase → UnloadDistributedZkTest
• AbstractCollectionsAPIDistributedZkTestBase → CollectionsAPIDistributedZkTest
• AbstractDistribZkTestBase → AbstractFullDistribZkTestBase

HDFS Reference Cleanup:

• Renamed moveHdfsReplica to moveSharedFsReplica in MoveReplicaCmd.java
• Updated log messages to use "SharedFs" instead of "HDFS"
• Removed obsolete HDFS-specific test method testTlogReplayWithKillRecoveringReplica
• Cleaned up HDFS references in AbstractCloudBackupRestoreTestCase
• Removed testMoveReplicaToSharedFs() test that is now obsolete

Updated dependent references in:

• OverriddenZkACLAndCredentialsProvidersTest
• OutOfBoxZkACLAndCredentialsProvidersTest
• All test classes that referenced AbstractDistribZkTestBase now use AbstractFullDistribZkTestBase

Retained abstract classes (still have multiple subclasses in core or modules):

• AbstractCloudBackupRestoreTestCase, AbstractIncrementalBackupTest, AbstractInstallShardTest, AbstractBackupRepositoryTest
• AbstractFullDistribZkTestBase, AbstractZkTestCase

Notes:

• The blockcache code is being kept with expectation of use beyond HDFS

Tests

Compilation verified. Test execution validated. Code formatting applied via ./gradlew tidy.

Checklist

• I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
• I have created a Jira issue and added the issue ID to my pull request title.
• I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
• I have developed this patch against the main branch.
• I have run ./gradlew check.
• I have added tests for my changes.
• I have added documentation for the Reference Guide
• I have added a changelog entry for my change

Original prompt

Can you elminate AbstractRestartWhileUpdatingTestBase by merging into RestartWhileUpdatingTest the unique aspects? Please remove the reference to HDFS contrib as that is no longer present.

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[epugh]

@copilot Can you run the gradlew tidy commmand?

[Copilot]

@copilot Can you run the gradlew tidy commmand?

Done. Ran ./gradlew tidy and committed the formatting changes in 81aa453.

[epugh]

@copilot Looks like AbstractFullDistribZkTestBase extends AbstractDistribZkTestBase and that is the only one who extends AbstractDistribZkTestBase. Can they be merged into just a single file?

[Copilot]

@copilot Looks like AbstractFullDistribZkTestBase extends AbstractDistribZkTestBase and that is the only one who extends AbstractDistribZkTestBase. Can they be merged into just a single file?

Merged AbstractDistribZkTestBase into AbstractFullDistribZkTestBase in commit e99e5fc. Updated all references across the codebase.

[epugh]

Just go ahead and rename the method..

[epugh]

@copilot Based on all the changes to this branch, can you update the summary for the PR?

[Copilot]

@copilot Based on all the changes to this branch, can you update the summary for the PR?

Updated the PR description with a comprehensive summary of all changes including the abstract test class consolidation, HDFS reference cleanup, and notes about retained abstract classes.