Merged
Conversation
CHr15F0x
changed the title
CHr15F0x
force-pushed
the
chris/p2p-sync-test-improvements
branch
from
754fedb to
6950607
Compare
vbar
reviewed
Apr 28, 2026
vbar
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At some point we moved to unbounded channels but the tests remained as if the channels were bounded. This PR fixes this issue, removing a bunch of helper test utils on the way.
I want this to be cleaned up because I'd like to use the TestPeer in the new
preconfirmednetwork tests.