feat: consensus protobuf upgrade + refactor#3365
Merged
Conversation
CHr15F0x
reviewed
Apr 28, 2026
CHr15F0x
reviewed
Apr 28, 2026
CHr15F0x
approved these changes
Apr 28, 2026
Contributor
CHr15F0x
left a comment
CHr15F0x
left a comment
There was a problem hiding this comment.
LGTM
I've initially been wondering about fin_payload but looks like we don't need to validate it if it appears, cause the proposal_commitment is sufficient.
The only question is: what if somebody does provide that field and it contains invalid commitments while the final proposal commitment is correct 🤔 . Do we just ignore it (as now) or treat it as malicious behavior?
Contributor
Author
IMHO we should ask why it's there & when it's set, and if it looks like it's going to stay, handle it in a follow-up issue... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following current https://github.com/starknet-io/starknet-p2p-specs/blob/main/p2p/proto/consensus/consensus.proto ,
folding
ProposalPart::BlockInfointoProposalInitandExecutedTransactionCountintoProposalFin.Fixes #3338 .