feat(sync): new incremental pre-confirmed block for Starknet 0.14.3#3368
Draft
feat(sync): new incremental pre-confirmed block for Starknet 0.14.3#3368
Conversation
…ewayApi::preconfirmed_block`
…major file tidy up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a tentative pre-confirmed block cumulative polling logic, which is expected to land in next Starknet version.
Note: I spent a lot of time tidying up the
pending.rsfile. The diff might be a mess. I encourage any reviewer to read the file itself instead. The code should now be super clean and easy to follow, plus I added comments everywhere for explicitness.Closes #3352