feat(p2p): preconfirmed p2p network scaffolding - part 2 - core p2p CLI options#3375
Open
feat(p2p): preconfirmed p2p network scaffolding - part 2 - core p2p CLI options#3375
Conversation
…etwork (preconfirmed)
CHr15F0x
force-pushed
the
chris/preconfirmed-p2p-cli
branch
from
068db45 to
3e7e332
Compare
zvolin
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preconfirmed p2p tracking issue: #3349
Fixes: #3377
Each p2p network that Pathfinder participates in has CLI options that share a common core set of settings. This PR adds this set of CLI options in the
p2p.preconfirmed.*namespace, as opposed to the already existingp2p.sync.*andp2p.consensus.*ones.No preconfirmed-p2p-network-specific options are added yet, because there is no spec yet.
Interestingly the consensus p2p network doesn't have its own specific cli options either, as opposed to the sync p2p network.