Use a default helm kube version of 1.30 #120
Open
+40
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivy uses helm to render helm charts for analysis. Helm client defaults to a kube version of 1.20. Trivy allows this to be overridden and the trivy-buildkite-plugin allows this argument to be specified #118.
This PR sets the kube version argument to a more recent version of 1.30 if it's not specified in the plugin config. This could be a more sensible default for the plugin. It prevents Trivy from failing if you don't configure the
kube-versionplugin option scan a helm chart that has a kube version of >1.20 as a requirement.If a different version of kube is needed, this can still be passed in as an argument as per #118.