Coma separator handling in greaterThan and lessThen validators

eranitach · Sep 19, 2014 · e02fa35 · e02fa35
1 parent 875194d
commit e02fa35
Show file tree

Hide file tree

Showing 9 changed files with 64 additions and 7 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,3 +1,4 @@
 .idea
 _gh_pages
-node_modules
+node_modules
+bower_components
diff --git a/dist/css/bootstrapValidator.min.css b/dist/css/bootstrapValidator.min.css
@@ -2,7 +2,7 @@
  * BootstrapValidator (http://bootstrapvalidator.com)
  * The best jQuery plugin to validate form fields. Designed to use with Bootstrap 3
  *
- * @version     v0.5.2-dev, built on 2014-09-18 8:09:53 AM
+ * @version     v0.5.2-dev, built on 2014-09-19 6:26:49 PM
  * @author      https://twitter.com/nghuuphuoc
  * @copyright   (c) 2013 - 2014 Nguyen Huu Phuoc
  * @license     MIT

diff --git a/dist/js/bootstrapValidator.js b/dist/js/bootstrapValidator.js
@@ -2,7 +2,7 @@
  * BootstrapValidator (http://bootstrapvalidator.com)
  * The best jQuery plugin to validate form fields. Designed to use with Bootstrap 3
  *
- * @version     v0.5.2-dev, built on 2014-09-18 8:09:53 AM
+ * @version     v0.5.2-dev, built on 2014-09-19 6:26:49 PM
  * @author      https://twitter.com/nghuuphuoc
  * @copyright   (c) 2013 - 2014 Nguyen Huu Phuoc
  * @license     MIT
@@ -2908,6 +2908,9 @@ if (typeof jQuery === 'undefined') {
             if (value === '') {
                 return true;
             }
+            if (value.indexOf(',') > -1){
+                value = value.replace(',', '.');
+            }
             if (!$.isNumeric(value)) {
                 return false;
             }
@@ -5157,6 +5160,9 @@ if (typeof jQuery === 'undefined') {
             if (value === '') {
                 return true;
             }
+            if (value.indexOf(',') > -1){
+                value = value.replace(',', '.');
+            }
             if (!$.isNumeric(value)) {
                 return false;
             }

diff --git a/dist/js/bootstrapValidator.min.js b/dist/js/bootstrapValidator.min.js
diff --git a/src/js/validator/greaterThan.js b/src/js/validator/greaterThan.js
@@ -44,6 +44,9 @@
             if (value === '') {
                 return true;
             }
+            if (value.indexOf(',') > -1){
+                value = value.replace(',', '.');
+            }
             if (!$.isNumeric(value)) {
                 return false;
             }

diff --git a/src/js/validator/lessThan.js b/src/js/validator/lessThan.js
@@ -44,6 +44,9 @@
             if (value === '') {
                 return true;
             }
+            if (value.indexOf(',') > -1){
+                value = value.replace(',', '.');
+            }
             if (!$.isNumeric(value)) {
                 return false;
             }

diff --git a/test/spec.js b/test/spec.js
@@ -2827,6 +2827,17 @@ describe('greaterThan', function() {
         expect(this.bv.isValid()).toBeTruthy();
     });
 
+    it('value with coma separator', function() {
+        this.$age.val('10,4');
+        this.bv.validate();
+        expect(this.bv.isValid()).toEqual(false);
+
+        this.bv.resetForm();
+        this.$age.val('18,678');
+        this.bv.validate();
+        expect(this.bv.isValid()).toBeTruthy();
+    });
+
     it('compare to other field', function() {
         this.$age.attr('data-bv-greaterthan-value', 'minAge');
         this.bv.destroy();
@@ -4475,6 +4486,17 @@ describe('lessThan', function() {
         expect(this.bv.isValid()).toEqual(false);
     });
 
+    it('value with coma separator', function() {
+        this.$age.val('120,2234');
+        this.bv.validate();
+        expect(this.bv.isValid()).toEqual(false);
+
+        this.bv.resetForm();
+        this.$age.val('30,2234');
+        this.bv.validate();
+        expect(this.bv.isValid()).toBeTruthy();
+    });
+
     it('compare to value', function() {
         this.$age.val(120);
         this.bv.validate();

diff --git a/test/spec/validator/greaterThan.js b/test/spec/validator/greaterThan.js
@@ -56,6 +56,17 @@ describe('greaterThan', function() {
         expect(this.bv.isValid()).toBeTruthy();
     });
 
+    it('value with coma separator', function() {
+        this.$age.val('10,4');
+        this.bv.validate();
+        expect(this.bv.isValid()).toEqual(false);
+
+        this.bv.resetForm();
+        this.$age.val('18,678');
+        this.bv.validate();
+        expect(this.bv.isValid()).toBeTruthy();
+    });
+
     it('compare to other field', function() {
         this.$age.attr('data-bv-greaterthan-value', 'minAge');
         this.bv.destroy();

diff --git a/test/spec/validator/lessThan.js b/test/spec/validator/lessThan.js
@@ -45,6 +45,17 @@ describe('lessThan', function() {
         expect(this.bv.isValid()).toEqual(false);
     });
 
+    it('value with coma separator', function() {
+        this.$age.val('120,2234');
+        this.bv.validate();
+        expect(this.bv.isValid()).toEqual(false);
+
+        this.bv.resetForm();
+        this.$age.val('30,2234');
+        this.bv.validate();
+        expect(this.bv.isValid()).toBeTruthy();
+    });
+
     it('compare to value', function() {
         this.$age.val(120);
         this.bv.validate();