Remove mempool conflicts for every applied transaction - #2526
Open
a-shannon wants to merge 1 commit into
Open
Conversation
a-shannon
marked this pull request as ready for review
September 6, 2026 23:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Block application now removes input conflicts even when the applied transaction was never in the local mempool. Previously, the batch cleanup skipped such a transaction entirely. The helper preserves removal statistics when the applied transaction itself is absent.
Validation: JDK 8, Scala 2.12.20; 46 tests pass across five mempool suites. Five direct cases cover absent winners, unchanged statistics without conflicts, multiple inputs, repeated cleanup, index contents and retaining an unconfirmed child of a confirmed parent. Four cases fail against the original implementation. Independent source and test review completed.
This corrects immediate input-conflict cleanup. Asynchronous revalidation remains responsible for subsequent invalid-descendant cleanup. The lifecycle correction in #2517 has a separate invariant; combined runtime validation remains pending if they are integrated together.
All eight checks pass on the current head: CI results.